Add application quality gates to Woodpecker #22

Closed
opened 2026-11-07 21:51:00 +00:00 by martin · 2 comments
Owner

Goal

Add repository-owned application validation alongside existing global workflows.

Evidence

Woodpecker pipeline 56 ran automated PR review, which failed while parsing a changed-files API response. Its resolved configuration contained global review, release, Renovate validation, and scheduled flake-health workflows, but no Backstage build/test checks. This is not evidence of an application build failure.

Acceptance criteria

  • PRs run reproducible install, typecheck, lint, formatting, tests, and backend build.
  • Use a supported, declared Node toolchain initially; migrate install/script invocation to Bun as part of the Bun issue.
  • Validation requires neither a Forgejo token nor live catalog sync.
  • Failures and test timeouts are clearly reported.
  • Application checks are distinguishable from automated-review results.

Scope

Repository-owned configuration only; changing shared global workflows is outside this issue.

Phase

1 — Trustworthy foundation

## Goal Add repository-owned application validation alongside existing global workflows. ## Evidence Woodpecker pipeline 56 ran automated PR review, which failed while parsing a changed-files API response. Its resolved configuration contained global review, release, Renovate validation, and scheduled flake-health workflows, but no Backstage build/test checks. This is not evidence of an application build failure. ## Acceptance criteria - [ ] PRs run reproducible install, typecheck, lint, formatting, tests, and backend build. - [ ] Use a supported, declared Node toolchain initially; migrate install/script invocation to Bun as part of the Bun issue. - [ ] Validation requires neither a Forgejo token nor live catalog sync. - [ ] Failures and test timeouts are clearly reported. - [ ] Application checks are distinguishable from automated-review results. ## Scope Repository-owned configuration only; changing shared global workflows is outside this issue. ## Phase 1 — Trustworthy foundation
Author
Owner

Vault context: reuse shared CI where compatible

See projects/nixos/woodpecker-global-workflow-architecture.md. Existing policy deliberately injects shared workflows and preserves repository-owned workflows. Prefer compatible shared stages plus Backstage-specific supplemental checks rather than duplicating global policy.

The documented bun-astro rule matches bun.lock and package.json; its verification runs Astro checks/Biome and its publication/promotion stages have persistent effects. Coordinate with #20 and inspect the current rule and resolved pipeline configuration. Adding Bun must not be assumed to provide suitable Backstage quality gates or safe deployment behavior. Global validation documented here also has different event triggers from the proposed PR checks.

Keep changes in this repository unless separate infrastructure work is explicitly agreed.

## Vault context: reuse shared CI where compatible See [`projects/nixos/woodpecker-global-workflow-architecture.md`](https://code.martials.no/Personal/context-vault/src/branch/main/projects/nixos/woodpecker-global-workflow-architecture.md). Existing policy deliberately injects shared workflows and preserves repository-owned workflows. Prefer compatible shared stages plus Backstage-specific supplemental checks rather than duplicating global policy. The documented `bun-astro` rule matches `bun.lock` and `package.json`; its verification runs Astro checks/Biome and its publication/promotion stages have persistent effects. Coordinate with #20 and inspect the current rule and resolved pipeline configuration. Adding Bun must not be assumed to provide suitable Backstage quality gates or safe deployment behavior. Global validation documented here also has different event triggers from the proposed PR checks. Keep changes in this repository unless separate infrastructure work is explicitly agreed.
Author
Owner

Implemented in #41 (ci/quality-gates-22), which closes this issue on merge.

What was added

  • .woodpecker/application-checks.yaml, a repository-owned workflow triggered on pull requests and default-branch pushes (excluding Markdown and the generated catalog file).
  • Steps run on node:24-trixie using the checked-in Yarn 4.18.1 release: immutable install (with Python 3), typecheck, lint, formatting, unit tests, and backend build.
  • Checks are separate named steps, so the failing gate is obvious. The unit-test step wraps Jest in a 15-minute timeout and prints a dedicated message when it is exceeded.
  • No FORGEJO_TOKEN and no sync:forgejo, so validation is independent of live Forgejo data.
  • README.md documents the CI setup and its boundary from global workflows; AGENTS.md records the maintenance constraint.

Evidence

  • woodpecker-cli lint .woodpecker/application-checks.yaml — valid.
  • Woodpecker pipeline 98 (PR #41) resolved both application-checks and the global pr-review workflows. application-checks succeeded with every step green: install, typecheck, lint, formatting, unit tests, backend build.
  • This confirms the application results are distinguishable from automated-review results and that the checks run without repository secrets.

The Bun migration of install/script invocation remains with #20.

Implemented in #41 (`ci/quality-gates-22`), which closes this issue on merge. **What was added** - `.woodpecker/application-checks.yaml`, a repository-owned workflow triggered on pull requests and default-branch pushes (excluding Markdown and the generated catalog file). - Steps run on `node:24-trixie` using the checked-in Yarn 4.18.1 release: immutable install (with Python 3), typecheck, lint, formatting, unit tests, and backend build. - Checks are separate named steps, so the failing gate is obvious. The unit-test step wraps Jest in a 15-minute `timeout` and prints a dedicated message when it is exceeded. - No `FORGEJO_TOKEN` and no `sync:forgejo`, so validation is independent of live Forgejo data. - `README.md` documents the CI setup and its boundary from global workflows; `AGENTS.md` records the maintenance constraint. **Evidence** - `woodpecker-cli lint .woodpecker/application-checks.yaml` — valid. - Woodpecker pipeline **98** (PR #41) resolved both `application-checks` and the global `pr-review` workflows. `application-checks` succeeded with every step green: install, typecheck, lint, formatting, unit tests, backend build. - This confirms the application results are distinguishable from automated-review results and that the checks run without repository secrets. The Bun migration of install/script invocation remains with #20.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
Personal/backstage#22
No description provided.