fix(opencode): address issue-manager permission review #61
No reviewers
Labels
No labels
automerge
bug
dependencies
duplicate
help wanted
invalid
lang
rust
migrations
opencode
question
security
type
documentation
type
enhancement
type
maintenance
type
refactor
vulnerability
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Personal/nixos-configuration!61
Loading…
Reference in a new issue
No description provided.
Delete branch "opencode/issue-manager-review-fixes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up to the review on #53.
Changes
set_labelsas anupdate_issuefield rather than a separate MCP tool (verified against forgejo-mcp 3.3.0).issue-manager: comment, attachment, and label deletion, time-entry deletion, and issue-time reset.planmay edit~/.opencode/plan/**.buildandgeneralkeep the existing allow.Validation
just fmt— no changes.nix evalof the desktop OpenCode agent permissions — passed.nix build --dry-runof the desktop Home Manager activation — passed.just build desktopis blocked by an unrelated error:hyprland-qtutilswas removed upstream and is still referenced inshared/workstation/modules/hyprland/default.nix.Refs #53
3d491f7e3fe1309c6d97Review Summary
What was verified
default.nixis correct:readOnlyIssuePermissionsplacesforgejo_* denybefore the specific read allows (reads win, writes stay denied), andplan.permissionsappendsedit ~/.opencode/plan/** allowafteredit * denyso the plan directory is the only editable path.~is expanded foreditresources at config load, so the plan path matches as intended.executeout ofissueSkillPermissionsintocodeModePermission, concatenated only intocodingIssuePermissions, correctly keepsexecute * allowforbuild/generalwhileplan/explorefall back to the global* ask— matching SKILL.md's "read-only agents may need to approve Code Mode use." Per the docs,executeonly gates Code Mode itself; nested tools still enforce their own rules, so the forgejodeny/allowrules hold for read-only agents under Code Mode.issue-manager.md: all seven deletes/resets (comment, repo/org label, issue/comment attachment, time entry, time reset) are nowask, and since the frontmatter starts with* deny, the lateraskrules correctly override it. Coverage matches the prose definition of destructive operations; reversible metadata ops (label add/remove, dependency remove, state change) intentionally remainallow. The prose hunks are consistent with both the permission list anddefault.nix(issueWriteToolsare alreadyaskfor coding agents;forgejo_*deny covers read-only agents).set_labelscorrection is consistent acrossissue-manager.mdandSKILL.md(field ofupdate_issue, not a standalone tool). Tool-name/effect changes rest on the PR's stated verification against forgejo-mcp 3.3.0; I could not independently re-run that check in this environment (shell unavailable), but nothing in the diff contradicts the existing tool naming.~/.opencode/plan/**edit exception.Minor note
One wording nit in the new comment (non-blocking, style only).
Validation described in the PR (
just fmt,nix eval,nix build --dry-run) is appropriate for this change; thehyprland-qtutilsbuild blocker is correctly identified as unrelated.*🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: approve
Code review findings from opencode.
@ -63,1 +63,4 @@}];# Code Mode reaches the Forgejo MCP tools. Nested tool calls still enforce# their own permissions, so read-only agents do not receive it.