chore(renovate): remove obsolete default preset #6

Merged
martin merged 1 commit from chore/remove-obsolete-default-preset into main 2026-10-25 18:09:53 +00:00
Owner

Summary

  • Remove preset/default.json, now that consumers use the root default.
  • Remove guidance that said to keep the preset while in use.

Validation

  • just validate default.json
  • just validate org-inherited-config.json
## Summary - Remove `preset/default.json`, now that consumers use the root default. - Remove guidance that said to keep the preset while in use. ## Validation - `just validate default.json` - `just validate org-inherited-config.json`
chore(renovate): remove obsolete default preset
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
a6c4b511b4
Co-authored-by: OpenCode <opencode@anoma.ly>
martin self-assigned this 2026-10-25 18:07:03 +00:00
Member

Review Summary

This PR cleanly removes preset/default.json and the two guidance lines that told agents to keep it while consumers still relied on it.

What looks good:

  • No dangling references remain anywhere in the repo: AGENTS.md, .opencode/skills/renovate-presets/SKILL.md, README.md, justfile, CODEOWNERS, default.json, org-inherited-config.json, and all remaining preset/*.json were checked. The only occurrences of the removed text are in the PR scratch diff artifact, not tracked files.
  • org-inherited-config.json extends the root default (Personal/renovate-config), not the deleted preset, so organization onboarding is unaffected.
  • No CI/workflow enumerates preset files; just validate *ARGS takes explicit paths, so nothing breaks when the file disappears. The PR's validation commands are appropriate.
  • Doc edits are consistent between AGENTS.md and SKILL.md; remaining example paths (preset/flake.json, preset/npm.json, preset/flake-lock.json) all exist.

Notes (non-blocking):

  • The removal is only safe if no external repository still extends Personal/renovate-config//preset/default — that failure mode (Renovate config validation error) cannot be observed from inside this repo, so it's worth a quick confirmation before merge.
  • Consumers migrating to the root default will pick up :semanticCommits, nix.enabled, and osvVulnerabilityAlerts that the deleted preset lacked. That's presumably intentional, but it's a behavior change worth stating in the PR description.

No correctness, security, or performance issues in the diff itself.


*🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: comment

# Review Summary This PR cleanly removes `preset/default.json` and the two guidance lines that told agents to keep it while consumers still relied on it. **What looks good:** - No dangling references remain anywhere in the repo: `AGENTS.md`, `.opencode/skills/renovate-presets/SKILL.md`, `README.md`, `justfile`, `CODEOWNERS`, `default.json`, `org-inherited-config.json`, and all remaining `preset/*.json` were checked. The only occurrences of the removed text are in the PR scratch diff artifact, not tracked files. - `org-inherited-config.json` extends the root default (`Personal/renovate-config`), not the deleted preset, so organization onboarding is unaffected. - No CI/workflow enumerates preset files; `just validate *ARGS` takes explicit paths, so nothing breaks when the file disappears. The PR's validation commands are appropriate. - Doc edits are consistent between `AGENTS.md` and `SKILL.md`; remaining example paths (`preset/flake.json`, `preset/npm.json`, `preset/flake-lock.json`) all exist. **Notes (non-blocking):** - The removal is only safe if no external repository still extends `Personal/renovate-config//preset/default` — that failure mode (Renovate config validation error) cannot be observed from inside this repo, so it's worth a quick confirmation before merge. - Consumers migrating to the root default will pick up `:semanticCommits`, `nix.enabled`, and `osvVulnerabilityAlerts` that the deleted preset lacked. That's presumably intentional, but it's a behavior change worth stating in the PR description. No correctness, security, or performance issues in the diff itself. --- *🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: **comment** <!-- forgejo-opencode-review -->
clank-bot left a comment

Code review findings from opencode.

Code review findings from opencode. <!-- forgejo-opencode-review -->
@ -1,6 +1,6 @@
# Renovate Config
- This repository publishes shared Renovate configuration, not application code. Root `default.json` is the canonical shared default; `org-inherited-config.json` supplies organization onboarding that extends it. Keep `preset/default.json` while existing consumers still use it.
Member
[bug] The removed guidance ('Keep preset/default.json while existing consumers still use it') is only safe to drop once no repository still extends `Personal/renovate-config//preset/default`. A stale consumer would fail Renovate config validation with a 'preset not found' error, which is invisible from within this repo. Please confirm downstream consumers were migrated before merging (non-blocking if already verified in the PR discussion).
<!-- forgejo-opencode-review --> [bug] The removed guidance ('Keep preset/default.json while existing consumers still use it') is only safe to drop once no repository still extends `Personal/renovate-config//preset/default`. A stale consumer would fail Renovate config validation with a 'preset not found' error, which is invisible from within this repo. Please confirm downstream consumers were migrated before merging (non-blocking if already verified in the PR discussion).
martin merged commit 48d5c663e1 into main 2026-10-25 18:09:53 +00:00
martin deleted branch chore/remove-obsolete-default-preset 2026-10-25 18:09:53 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Personal/renovate-config!6
No description provided.