Release the review plugin pagination fix and validate it in CI #76
Labels
No labels
plugin/bun2nix
plugin/cargo-build
plugin/cargo-clippy
plugin/cargo-nextest
plugin/cargo-publish
plugin/cargo-verify
plugin/command-suite
plugin/flake-checker
plugin/flake-lock-report
plugin/forgejo-file-sync
plugin/forgejo-opencode-review
plugin/forgejo-pr-merge
plugin/forgejo-release
plugin/new
plugin/nix-build
plugin/nixidy-cli
plugin/nixidy-switch
plugin/nix-unit
plugin/ntfy
plugin/oci-build-push
plugin/oci-copy
plugin/openapi-to-rust
plugin/path-filter
plugin/renovate-config-check
plugin/woodpecker-lint
type
feature
type
task
automerge
bug
dependencies
duplicate
help wanted
invalid
lang
rust
migrations
opencode
question
security
type
documentation
type
enhancement
type
maintenance
type
refactor
vulnerability
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Reference
Personal/woodpecker-plugins#76
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Release and deploy the forgejo-opencode-review pagination compatibility fix so CI no longer fails on Forgejo HTTP 200
nullterminal pages.Context
Pipeline https://ci.martials.no/repos/7/pipeline/169 uses image version 0.2.2 and fails while listing changed files for martin/nixos-configuration#53. Page 1 returns six files; page 2 returns
null, contrary to the array response schema in Forgejo 17.0.1.The source fix is commit
f48383a: stop after short pages and accept only HTTP 200 bodies containing JSONnullas empty pages. Dependencies and the plugin version were not changed. Validation passed:cargo test --locked -p forgejo-opencode-review(20 tests),just test,just lint,just build, andcargo fmt --all -- --check. No OCI image was built or released and the consuming global workflow was not modified.Scope
Acceptance criteria
f48383a.Out of scope
Changing Forgejo, its published API contract, or the my-clients generator.
Progress
The source fix (
f48383a) is pushed tofix/forgejo-review-paginationand proposed in #77. Review has been requested fromclank-bot. All local validation listed above passed. Release/deployment remains pending; this issue stays open.Context
The upstream report https://codeberg.org/forgejo/forgejo/issues/14982 describes this exact failure: the changed-files endpoint returns HTTP 200
nullfor out-of-range pages. The report traces it to the Forgejo 17.0.0 refactor replacing an initialized empty slice with a nil slice; it proposes restoring slice initialization so empty pages serialize as[]. The ticket is currently open.This supports keeping the contract and generated client array type unchanged. Our plugin-local workaround accepts both
[]and the buggynull, so it remains compatible when Forgejo fixes its server response.