Release the review plugin pagination fix and validate it in CI #76

Open
opened 2026-11-08 19:34:35 +00:00 by martin · 2 comments
Owner

Summary

Release and deploy the forgejo-opencode-review pagination compatibility fix so CI no longer fails on Forgejo HTTP 200 null terminal pages.

Context

Pipeline https://ci.martials.no/repos/7/pipeline/169 uses image version 0.2.2 and fails while listing changed files for martin/nixos-configuration#53. Page 1 returns six files; page 2 returns null, contrary to the array response schema in Forgejo 17.0.1.

The source fix is commit f48383a: stop after short pages and accept only HTTP 200 bodies containing JSON null as empty pages. Dependencies and the plugin version were not changed. Validation passed: cargo test --locked -p forgejo-opencode-review (20 tests), just test, just lint, just build, and cargo fmt --all -- --check. No OCI image was built or released and the consuming global workflow was not modified.

Scope

  • Bump the plugin patch version and update Cargo.lock.
  • Build and release its OCI image using the repository release workflow.
  • Coordinate updating the consuming global PR-review workflow image tag in its owning repository.
  • Rerun the affected PR review and inspect its logs.

Acceptance criteria

  • A new versioned review plugin image contains commit f48383a.
  • The consuming PR-review workflow uses that image.
  • A CI review with a short changed-files page proceeds past changed-file collection.
  • Record the release tag and successful pipeline evidence.

Out of scope

Changing Forgejo, its published API contract, or the my-clients generator.

## Summary Release and deploy the forgejo-opencode-review pagination compatibility fix so CI no longer fails on Forgejo HTTP 200 `null` terminal pages. ## Context Pipeline https://ci.martials.no/repos/7/pipeline/169 uses image version 0.2.2 and fails while listing changed files for martin/nixos-configuration#53. Page 1 returns six files; page 2 returns `null`, contrary to the array response schema in Forgejo 17.0.1. The source fix is commit `f48383a`: stop after short pages and accept only HTTP 200 bodies containing JSON `null` as empty pages. Dependencies and the plugin version were not changed. Validation passed: `cargo test --locked -p forgejo-opencode-review` (20 tests), `just test`, `just lint`, `just build`, and `cargo fmt --all -- --check`. No OCI image was built or released and the consuming global workflow was not modified. ## Scope - Bump the plugin patch version and update Cargo.lock. - Build and release its OCI image using the repository release workflow. - Coordinate updating the consuming global PR-review workflow image tag in its owning repository. - Rerun the affected PR review and inspect its logs. ## Acceptance criteria - [x] A new versioned review plugin image contains commit f48383a. - [x] The consuming PR-review workflow uses that image. - [ ] A CI review with a short changed-files page proceeds past changed-file collection. - [ ] Record the release tag and successful pipeline evidence. ## Out of scope Changing Forgejo, its published API contract, or the my-clients generator.
Author
Owner

Progress

The source fix (f48383a) is pushed to fix/forgejo-review-pagination and proposed in #77. Review has been requested from clank-bot. All local validation listed above passed. Release/deployment remains pending; this issue stays open.

## Progress The source fix (`f48383a`) is pushed to `fix/forgejo-review-pagination` and proposed in #77. Review has been requested from `clank-bot`. All local validation listed above passed. Release/deployment remains pending; this issue stays open.
Author
Owner

Context

The upstream report https://codeberg.org/forgejo/forgejo/issues/14982 describes this exact failure: the changed-files endpoint returns HTTP 200 null for out-of-range pages. The report traces it to the Forgejo 17.0.0 refactor replacing an initialized empty slice with a nil slice; it proposes restoring slice initialization so empty pages serialize as []. The ticket is currently open.

This supports keeping the contract and generated client array type unchanged. Our plugin-local workaround accepts both [] and the buggy null, so it remains compatible when Forgejo fixes its server response.

## Context The upstream report https://codeberg.org/forgejo/forgejo/issues/14982 describes this exact failure: the changed-files endpoint returns HTTP 200 `null` for out-of-range pages. The report traces it to the Forgejo 17.0.0 refactor replacing an initialized empty slice with a nil slice; it proposes restoring slice initialization so empty pages serialize as `[]`. The ticket is currently open. This supports keeping the contract and generated client array type unchanged. Our plugin-local workaround accepts both `[]` and the buggy `null`, so it remains compatible when Forgejo fixes its server response.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
Personal/woodpecker-plugins#76
No description provided.