feat: Add Playwright integration test #51

This PR adds a minimal Playwright end-to-end integration test for the Astro/Bun production startup. The implementation is clean and well-structured: a focused smoke test, proper config using Nix-provided Chromium via PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH, explicit reuseExistingServer: false to prevent stale processes, and thorough documentation in both AGENTS.md and README.md explaining the known Bun/Astro adapter issue (app.pipeline.getLogger undefined).

The prior review already flagged the flake.nix fish shell change (confirmed intentional by author) and the performance consideration around rebuild-per-test. No new correctness or security issues found. The large bun.lock/bun.nix dependency bumps are routine version updates and not concerning on their own.

*🤖 Review by opencode (opencode/mimo-v2.5-free) — verdict: approve

# Review Summary This PR adds a minimal Playwright end-to-end integration test for the Astro/Bun production startup. The implementation is clean and well-structured: a focused smoke test, proper config using Nix-provided Chromium via `PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH`, explicit `reuseExistingServer: false` to prevent stale processes, and thorough documentation in both `AGENTS.md` and `README.md` explaining the known Bun/Astro adapter issue (`app.pipeline.getLogger` undefined). The prior review already flagged the `flake.nix` fish shell change (confirmed intentional by author) and the performance consideration around rebuild-per-test. No new correctness or security issues found. The large `bun.lock`/`bun.nix` dependency bumps are routine version updates and not concerning on their own. --- *🤖 Review by opencode (opencode/mimo-v2.5-free) — verdict: **approve**

clank-bot reviewed

2026-09-11 17:41:18 +00:00

clank-bot left a comment

Code review findings from opencode.

Code review findings from opencode.

flake.nix

					
				@ -130,2 +130,4 @@

				              # Use the Nix browser instead of downloading Playwright browsers.

				              chromium

				            ];

				            shellHook = ''

[bug] The default devShell's `shellHook` previously ended with `fish` (launching an interactive fish shell session). The new version replaced that with only the `PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH` export, removing the `fish` invocation. The postgres shell at line 178 still has `fish`. This looks like an accidental regression — users entering `nix develop` (default shell) will no longer get a fish shell. If this is intentional, it should be noted in the commit message; otherwise, `fish` should be restored.

[bug] The default devShell's `shellHook` previously ended with `fish` (launching an interactive fish shell session). The new version replaced that with only the `PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH` export, removing the `fish` invocation. The postgres shell at line 178 still has `fish`. This looks like an accidental regression — users entering `nix develop` (default shell) will no longer get a fish shell. If this is intentional, it should be noted in the commit message; otherwise, `fish` should be restored.

This is intentional

martin marked this conversation as resolved

package.json Outdated

					
				@ -9,6 +9,7 @@

						"dev": "bunx --bun astro dev",

						"build": "bun run generate && bunx --bun astro build",

						"check": "bunx --bun astro check",

						"test:e2e": "bun run build && bunx playwright test",

[performance] The `test:e2e` script runs `bun run build && bunx playwright test`, which performs a full production build (including OpenAPI codegen) on every test invocation. This is correct for the production-startup test's intent, but consider splitting into a `build` step and a `test:e2e` step (only `bunx playwright test`) so CI can skip the rebuild when the build artifact is already available. The `just integration-test` recipe could call `just build` then `bunx playwright test` separately.

[performance] The `test:e2e` script runs `bun run build && bunx playwright test`, which performs a full production build (including OpenAPI codegen) on every test invocation. This is correct for the production-startup test's intent, but consider splitting into a `build` step and a `test:e2e` step (only `bunx playwright test`) so CI can skip the rebuild when the build artifact is already available. The `just integration-test` recipe could call `just build` then `bunx playwright test` separately.

playwright.config.ts

					
				@ -0,0 +27,4 @@

					],

					webServer: {

						// Use the compiled server to test production startup with Bun.

						command: "HOST=127.0.0.1 PORT=4323 bun dist/server/entry.mjs",

[style] The `webServer.command` uses inline env vars (`HOST=127.0.0.1 PORT=4323`). This works on Linux/macOS but would fail on Windows. Since this project targets Bun on Linux (per AGENTS.md), this is acceptable, but worth documenting that cross-platform support is not intended.

[style] The `webServer.command` uses inline env vars (`HOST=127.0.0.1 PORT=4323`). This works on Linux/macOS but would fail on Windows. Since this project targets Bun on Linux (per AGENTS.md), this is acceptable, but worth documenting that cross-platform support is not intended.

martin added 1 commit

2026-09-11 19:16:00 +00:00

Small fixes

ci/woodpecker/push/bun-verify Pipeline was successful

Details

ci/woodpecker/pr/pr-review Pipeline was successful

Details

70faf731a1