Require an Astro config in the bun-astro rule #68
Labels
No labels
automerge
bug
dependencies
duplicate
help wanted
invalid
lang
rust
migrations
opencode
question
security
type
documentation
type
enhancement
type
maintenance
type
refactor
vulnerability
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Personal/nixos-configuration#68
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Goal
Stop the global
bun-astrorule from matching non-Astro Bun repositories by requiring an Astro config file in addition tobun.lockandpackage.json.Context
The rule currently matches any repository whose root contains
bun.lockandpackage.json:Personal/backstagehaspackage.jsonand is adoptingbun.lockin #42, so it now matches even though it is a Backstage app, not Astro. The injected Bun workflow (bun-verify) runs Astro-only commands and fails.The extension already ANDs every
match_patternsentry against root file names and supports globs, so this is a repository-owned config change. Nowoodpecker-extensionrelease or repository-local opt-out is needed.Scope
rules.bun-astro.match_patternsinshared/base/modules/services/woodpecker/woodpecker-extension.nix.astro.config.*so.ts,.mjs, and.jsprojects still match;astro.config.tsalone would miss Astro's default.mjsvariant.bun.lockandpackage.jsonso the rule remains Bun-specific.woodpecker.tomlopt-out or a label-based rule exclusion.Acceptance criteria
rules.bun-astro.match_patternsrequiresbun.lock,package.json, and an Astro config (astro.config.*, orastro.config.tsif every Astro repo here uses TypeScript).Personal/backstageno longer matches the rule and receives none of the Bun global workflows (bun-verify/bun-push/bun-deploy, or theirglobal-bun-*names if #69 lands first).bun-verify, orglobal-bun-verifyafter #69).Related
woodpecker.tomlopt-out)Decision: use the direct
ignored_workflowsfeature from Personal/woodpecker-extension#50. This issue is now scoped to bumping and deploying the extension after #50 ships; thematch_not_labelsrule change is dropped.Bump woodpecker-extension and add a label opt-out to the bun-astro ruleto Bump woodpecker-extension to the release with ignored_workflows supportBump woodpecker-extension to the release with ignored_workflows supportto Require an Astro config in the bun-astro ruleScope changed after review: rather than bumping the extension and adding an opt-out, narrow
bun-astroso it requires an Astro config. The rule currently matches any root withbun.lock+package.json, which is why Personal/backstage is a false positive. This is now a one-linematch_patternschange in this repository; no extension release orwoodpecker.tomlfile is needed.Concrete change:
match_patternsis ANDed and matched against root file names, so all three must exist. Usingastro.config.*covers.ts,.mjs, and.js; if every Astro repository here uses TypeScript,astro.config.tsis equivalent. After deployment, a Backstage push pipeline should contain only the repository-ownedapplication-checksworkflow and no Bun verify workflow.If #69 lands first, the workflow keys and
workflowsentries above becomeglobal-bun-verify,global-bun-push, andglobal-bun-deploy; thematch_patternschange is unaffected.Progress
astro.config.*torules.bun-astro.match_patternsinshared/base/modules/services/woodpecker/woodpecker-extension.nix(commit4d2e812, pushed tomain).nidaros;woodpecker-extension.serviceactive with the updated rule in/etc/woodpecker-extension/config.toml.Validation
Personal/martials.nopipeline #261 (post-deploy push): resolvedbun-verify,bun-push, andbun-deploy.bun-verifyran and failed on the renovate dependency build, unrelated to the matcher.Personal/backstagepipeline #123 (PR, head61ebe6c= PR #42): resolved onlyflake-check,renovate-lint,pr-review,global-forgejo-release, andapplication-checks. Nobun-*workflow was injected.bun.lockandpackage.jsonbut no Astro config, covering the Bun-without-Astro case.mergeable: true.All acceptance criteria are satisfied.