fix(deps): replace dependency @material-ui/icons with @mui/icons-material ^5.0.0 - autoclosed #10
No reviewers
Labels
No labels
automerge
bug
dependencies
duplicate
help wanted
invalid
lang
rust
migrations
opencode
question
security
type
documentation
type
enhancement
type
maintenance
type
refactor
vulnerability
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Personal/backstage!10
Loading…
Reference in a new issue
No description provided.
Delete branch "renovate/material-ui-icons-replacement"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR contains the following updates:
^4.11.3→^5.0.0This is a special PR that replaces
@material-ui/iconswith the community suggested minimal stable replacement version.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.
Review Summary
The diff is limited to
packages/app/package.jsonandyarn.lock: it removes the direct@material-ui/icons@^4.11.3dependency and adds@mui/icons-material@^5.0.0(resolved to 5.18.0 in the lockfile). The lockfile changes are internally consistent — the new package entry, its@mui/material ^5.0.0peer, and the app workspace dependency list all match the manifest edit. No security, performance, or lockfile-integrity issues in what is changed.However, the replacement is still incomplete and both previously raised findings remain unaddressed:
packages/app/src/modules/nav/Sidebar.tsx:11-12still imports@material-ui/icons/Menuand@material-ui/icons/Search(rendered at lines 31 and 35). The old package now resolves only as a transitive/phantom dependency, so the declared new dependency is never actually imported and a hoisting change could break the build.@mui/icons-materialdeclares a peer on@mui/material ^5.0.0, which no workspace package declares directly (only present transitively via@backstage/theme), so installs rely on hoisting and emit peer warnings.No new issues beyond those already on the record; no new inline comments. Recommend addressing the leftover imports (and optionally declaring
@mui/material) before merge.*🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: changes
Code review findings from opencode.
@ -42,3 +42,3 @@"@backstage/ui": "^0.18.0","@material-ui/core": "^4.12.2","@material-ui/icons": "^4.9.1","@mui/icons-material": "^5.0.0",8032300fbb49e74fd8c849e74fd8c81c8bb826421c8bb826428b08f486828b08f48682ede71a4c06ede71a4c06d4ef75e9c9d4ef75e9c95b9c7456775b9c74567706178c857d06178c857d3115c8fa2ffix(deps): replace dependency @material-ui/icons with @mui/icons-material ^5.0.0to fix(deps): replace dependency @material-ui/icons with @mui/icons-material ^5.0.0 - autoclosedPull request closed