fix(deps): replace dependency @material-ui/icons with @mui/icons-material ^5.0.0 - autoclosed #10

Closed
renovate-bot wants to merge 1 commit from renovate/material-ui-icons-replacement into main
Member

This PR contains the following updates:

Package Type Update Change
@material-ui/icons (source) → @mui/icons-material dependencies replacement ^4.11.3 → ^5.0.0

This is a special PR that replaces @material-ui/icons with the community suggested minimal stable replacement version.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@material-ui/icons](https://github.com/mui-org/material-ui/tree/master/packages/material-ui-icons) ([source](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui-icons)) → [@mui/icons-material](https://github.com/mui-org/material-ui/tree/master/packages/material-ui-icons) | dependencies | replacement | [`^4.11.3` → `^5.0.0`](https://renovatebot.com/diffs/npm/@material-ui%2ficons/4.11.3/) | This is a special PR that replaces `@material-ui/icons` with the community suggested minimal stable replacement version. --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC43OS4yIiwidXBkYXRlZEluVmVyIjoiNDQuMTgxLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->
fix(deps): replace dependency @material-ui/icons with @mui/icons-material ^5.0.0
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
8032300fbb
Member

Review Summary

The diff is limited to packages/app/package.json and yarn.lock: it removes the direct @material-ui/icons@^4.11.3 dependency and adds @mui/icons-material@^5.0.0 (resolved to 5.18.0 in the lockfile). The lockfile changes are internally consistent — the new package entry, its @mui/material ^5.0.0 peer, and the app workspace dependency list all match the manifest edit. No security, performance, or lockfile-integrity issues in what is changed.

However, the replacement is still incomplete and both previously raised findings remain unaddressed:

  1. packages/app/src/modules/nav/Sidebar.tsx:11-12 still imports @material-ui/icons/Menu and @material-ui/icons/Search (rendered at lines 31 and 35). The old package now resolves only as a transitive/phantom dependency, so the declared new dependency is never actually imported and a hoisting change could break the build.
  2. @mui/icons-material declares a peer on @mui/material ^5.0.0, which no workspace package declares directly (only present transitively via @backstage/theme), so installs rely on hoisting and emit peer warnings.

No new issues beyond those already on the record; no new inline comments. Recommend addressing the leftover imports (and optionally declaring @mui/material) before merge.


*🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: changes

# Review Summary The diff is limited to `packages/app/package.json` and `yarn.lock`: it removes the direct `@material-ui/icons@^4.11.3` dependency and adds `@mui/icons-material@^5.0.0` (resolved to 5.18.0 in the lockfile). The lockfile changes are internally consistent — the new package entry, its `@mui/material ^5.0.0` peer, and the app workspace dependency list all match the manifest edit. No security, performance, or lockfile-integrity issues in what is changed. However, the replacement is still incomplete and both previously raised findings remain unaddressed: 1. `packages/app/src/modules/nav/Sidebar.tsx:11-12` still imports `@material-ui/icons/Menu` and `@material-ui/icons/Search` (rendered at lines 31 and 35). The old package now resolves only as a transitive/phantom dependency, so the declared new dependency is never actually imported and a hoisting change could break the build. 2. `@mui/icons-material` declares a peer on `@mui/material ^5.0.0`, which no workspace package declares directly (only present transitively via `@backstage/theme`), so installs rely on hoisting and emit peer warnings. No new issues beyond those already on the record; no new inline comments. Recommend addressing the leftover imports (and optionally declaring `@mui/material`) before merge. --- *🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: **changes** <!-- forgejo-opencode-review -->
clank-bot left a comment

Code review findings from opencode.

Code review findings from opencode. <!-- forgejo-opencode-review -->
@ -42,3 +42,3 @@
"@backstage/ui": "^0.18.0",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@mui/icons-material": "^5.0.0",
Member
[bug] Removing the direct dependency on @material-ui/icons leaves existing code broken-by-intent: packages/app/src/modules/nav/Sidebar.tsx lines 11-12 still import '@material-ui/icons/Menu' and '@material-ui/icons/Search' (rendered at lines 31 and 35). Those imports currently resolve only because @material-ui/icons is hoisted transitively from other Backstage packages, making it a phantom dependency that can silently break the build. Please update Sidebar.tsx to import from '@mui/icons-material/Menu' and '@mui/icons-material/Search' as part of this replacement PR.
<!-- forgejo-opencode-review --> [bug] Removing the direct dependency on @material-ui/icons leaves existing code broken-by-intent: packages/app/src/modules/nav/Sidebar.tsx lines 11-12 still import '@material-ui/icons/Menu' and '@material-ui/icons/Search' (rendered at lines 31 and 35). Those imports currently resolve only because @material-ui/icons is hoisted transitively from other Backstage packages, making it a phantom dependency that can silently break the build. Please update Sidebar.tsx to import from '@mui/icons-material/Menu' and '@mui/icons-material/Search' as part of this replacement PR.
Member
[style] @mui/icons-material declares a peer dependency on @mui/material ^5.0.0, but no workspace package declares @mui/material directly (it is only available transitively). Yarn will emit peer-dependency warnings and the resolution currently relies on hoisting; consider adding "@mui/material": "^5.18.0" to this package's dependencies for an explicit, stable install.
<!-- forgejo-opencode-review --> [style] @mui/icons-material declares a peer dependency on @mui/material ^5.0.0, but no workspace package declares @mui/material directly (it is only available transitively). Yarn will emit peer-dependency warnings and the resolution currently relies on hoisting; consider adding "@mui/material": "^5.18.0" to this package's dependencies for an explicit, stable install.
renovate-bot force-pushed renovate/material-ui-icons-replacement from 8032300fbb
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
to 49e74fd8c8
Some checks failed
ci/woodpecker/pr/pr-review Pipeline failed
2026-11-03 18:11:07 +00:00
Compare
renovate-bot force-pushed renovate/material-ui-icons-replacement from 49e74fd8c8
Some checks failed
ci/woodpecker/pr/pr-review Pipeline failed
to 1c8bb82642
Some checks failed
ci/woodpecker/pr/pr-review Pipeline failed
2026-11-08 00:01:44 +00:00
Compare
renovate-bot force-pushed renovate/material-ui-icons-replacement from 1c8bb82642
Some checks failed
ci/woodpecker/pr/pr-review Pipeline failed
to 8b08f48682
Some checks failed
ci/woodpecker/pr/pr-review Pipeline failed
2026-11-08 15:26:51 +00:00
Compare
renovate-bot force-pushed renovate/material-ui-icons-replacement from 8b08f48682
Some checks failed
ci/woodpecker/pr/pr-review Pipeline failed
to ede71a4c06
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
2026-11-16 23:02:49 +00:00
Compare
renovate-bot force-pushed renovate/material-ui-icons-replacement from ede71a4c06
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
to d4ef75e9c9
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
2026-11-17 20:39:53 +00:00
Compare
renovate-bot force-pushed renovate/material-ui-icons-replacement from d4ef75e9c9
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
to 5b9c745677
Some checks failed
ci/woodpecker/pr/pr-review Pipeline was successful
ci/woodpecker/pr/application-checks Pipeline was canceled
2026-11-18 23:04:07 +00:00
Compare
martin removed review request for clank-bot 2026-11-19 07:06:53 +00:00
renovate-bot force-pushed renovate/material-ui-icons-replacement from 5b9c745677
Some checks failed
ci/woodpecker/pr/pr-review Pipeline was successful
ci/woodpecker/pr/application-checks Pipeline was canceled
to 06178c857d
Some checks failed
ci/woodpecker/pr/pr-review Pipeline was successful
ci/woodpecker/pr/application-checks Pipeline failed
2026-11-19 23:03:52 +00:00
Compare
renovate-bot force-pushed renovate/material-ui-icons-replacement from 06178c857d
Some checks failed
ci/woodpecker/pr/pr-review Pipeline was successful
ci/woodpecker/pr/application-checks Pipeline failed
to 3115c8fa2f
Some checks failed
ci/woodpecker/pr/application-checks Pipeline was canceled
ci/woodpecker/pr/pr-review Pipeline was successful
2026-11-20 20:30:37 +00:00
Compare
renovate-bot changed title from fix(deps): replace dependency @material-ui/icons with @mui/icons-material ^5.0.0 to fix(deps): replace dependency @material-ui/icons with @mui/icons-material ^5.0.0 - autoclosed 2026-11-21 23:17:35 +00:00
renovate-bot closed this pull request 2026-11-21 23:17:37 +00:00
Some checks failed
ci/woodpecker/pr/application-checks Pipeline was canceled
ci/woodpecker/pr/pr-review Pipeline was successful

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Personal/backstage!10
No description provided.