fix(deps): replace dependency @material-ui/core with @mui/material ^5.0.0 - autoclosed #9
No reviewers
Labels
No labels
automerge
bug
dependencies
duplicate
help wanted
invalid
lang
rust
migrations
opencode
question
security
type
documentation
type
enhancement
type
maintenance
type
refactor
vulnerability
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Personal/backstage!9
Loading…
Reference in a new issue
No description provided.
Delete branch "renovate/material-ui-core-replacement"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR contains the following updates:
^4.12.4→^5.0.0This is a special PR that replaces
@material-ui/corewith the community suggested minimal stable replacement version.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.
I'll review this PR by checking if the codebase still uses
@material-ui/coreand whether this replacement is safe.{
"summary": "# Review Summary\n\nThis Renovate auto-generated replacement PR swaps
@material-ui/corefor@mui/materialinpackages/app/package.jsonbut does not migrate any application code. That makes the change incomplete and unsafe to merge as-is.\n\n## Blocking issues\n\n1. Source files still import the removed package\n\nThe following files importmakeStylesdirectly from@material-ui/core:\n\n-packages/app/src/modules/nav/LogoFull.tsx:1\n-packages/app/src/modules/nav/LogoIcon.tsx:1\n-packages/app/src/modules/nav/SidebarLogo.tsx:6\n\nAfter this change,@material-ui/coreis no longer a declared dependency ofpackages/app. Resolution may still "work" via hoisting from@backstage/*packages, but that is an undeclared/transitive dependency — fragile, incorrect under strict installers (e.g. Yarn PnP), and contrary to the PR's stated goal of removing@material-ui/core.\n\n2.makeStylesis not a drop-in export of@mui/materialv5\n\nEven if the import paths were updated to@mui/material,makeStyleswould not resolve: in MUI v5 it lives in the deprecated@mui/stylespackage and uses a separate JSS setup. A simple package-name swap cannot satisfy these call sites. A real migration needs either@mui/styles(not recommended) or a refactor tosx/styled/emotion (or plain CSS) for these simple SVG styles.\n\n## Other notes\n\n-@material-ui/icons^4.9.1 is left in place (used inSidebar.tsx) while@material-ui/coreis removed. That leaves an inconsistent MUI v4/v5 mix and keeps a package whose v4 line is peer-linked to@material-ui/core. Prefer@mui/icons-materialas part of the same migration.\n- Theyarn.lockhunk correctly merges^5.0.0with the existing^5.12.2range onto resolution 5.18.0, so no duplicate@mui/materialcopies are introduced. The lockfile also confirms@material-ui/corewas dropped from the app package's direct dependency metadata.\n\n## Recommendation\n\nRequest changes. Either close this Renovate PR and handle the migration manually, or extend it to update the threeLogo*/SidebarLogofiles (and optionally@material-ui/icons→@mui/icons-material) so the workspace builds without relying on undeclared transitive deps. Please runyarn tsc/yarn build:backend(and a clean install without hoisting assumptions) before merge.","verdict": "changes",
"comments": [
{
"file": "packages/app/package.json",
"line": 43,
"side": "new",
"severity": "bug",
"message": "Incomplete replacement:
@material-ui/coreis removed here, but app source still imports it (LogoFull.tsx,LogoIcon.tsx,SidebarLogo.tsxuseimport { makeStyles } from '@material-ui/core'). Builds may only pass via hoisted transitive deps from@backstage/*, which is undeclared and fragile. Also notemakeStylesis not exported from@mui/materialv5 (it moved to deprecated@mui/styles), so renaming the dependency alone is not sufficient — the three call sites need a real migration (e.g.sx/styled) or an explicit@mui/stylesdependency."},
{
"file": "packages/app/src/modules/nav/LogoFull.tsx",
"line": 1,
"side": "new",
"severity": "bug",
"message": "Still imports
makeStylesfrom@material-ui/core, which this PR removes frompackages/appdependencies. Update this import as part of the migration;@mui/materialv5 does not providemakeStyles."},
{
"file": "packages/app/src/modules/nav/LogoIcon.tsx",
"line": 1,
"side": "new",
"severity": "bug",
"message": "Still imports
makeStylesfrom@material-ui/core, which this PR removes frompackages/appdependencies. Update this import as part of the migration;@mui/materialv5 does not providemakeStyles."},
{
"file": "packages/app/src/modules/nav/SidebarLogo.tsx",
"line": 6,
"side": "new",
"severity": "bug",
"message": "Still imports
makeStylesfrom@material-ui/core, which this PR removes frompackages/appdependencies. Update this import as part of the migration;@mui/materialv5 does not providemakeStyles."},
{
"file": "packages/app/package.json",
"line": 44,
"side": "new",
"severity": "style",
"message": "
@material-ui/icons^4.9.1 remains after removing@material-ui/core, leaving a mixed MUI v4/v5 dependency set (icons v4 is peer-linked to@material-ui/core). Consider migrating icons to@mui/icons-materialin the same change for consistency."}
]
}
*🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: comment
1a56dae785964786448f964786448f3ce01292ba3ce01292ba7ca664ccaa7ca664ccaacde391cd3ecde391cd3e5078d55b685078d55b68e07dac89d4e07dac89d43cd6a87ad03cd6a87ad092f6e6e5fdfix(deps): replace dependency @material-ui/core with @mui/material ^5.0.0to fix(deps): replace dependency @material-ui/core with @mui/material ^5.0.0 - autoclosedPull request closed