refactor(renovate): consolidate shared default config #5
No reviewers
Labels
No labels
automerge
bug
dependencies
duplicate
help wanted
invalid
lang
rust
migrations
opencode
question
security
type
documentation
type
enhancement
type
maintenance
type
refactor
vulnerability
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Personal/renovate-config!5
Loading…
Reference in a new issue
No description provided.
Delete branch "refactor/consolidate-default-config"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
preset/default.jsoninto the rootdefault.json.preset/default.jsonfor existing consumers and update repository guidance.Validation
just validate default.jsonjust validate org-inherited-config.jsonReview Summary
Correctness checks (this version of the diff)
default.jsonretains:semanticCommits,"nix": {"enabled": true}and"osvVulnerabilityAlerts": true, and only adds:enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)plus"labels": ["dependencies"]. The previously raised concerns about silently dropping Nix/OSV/semantic-commit settings do not apply to the current diff.:enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)is a real internal preset (it setsvulnerabilityAlerts.enabled = trueplusaddLabels: ["vulnerability"]), and it composes cleanly withosvVulnerabilityAlertsand the repo-levellabelsentry —addLabelsmerges withlabels, so security PRs get both labels rather than replacing them.org-inherited-config.json's newPersonal/renovate-configreference is valid: an unprefixedowner/repostring parses as alocal-source preset withpresetName: "default", so it resolves todefault.jsonon the default branch — exactly equivalent to the old//preset/defaultform, just pointing at the root file. Docs inAGENTS.mdand.opencode/skills/renovate-presets/SKILL.mddescribe this correctly and are consistent with each other.just validate <path>guidance.Notes (non-blocking)
preset/default.json, but the result is a merge that also introduces two behaviors existing root-default consumers did not have before (vulnerability-alert PRs and thedependencieslabel). Worth one line in the description so downstream maintainers can see the additions, not just the consolidation.default.jsonis now a strict superset ofpreset/default.json, so the two defaults can still drift apart in the future; the previously suggested thin-wrapper follow-up forpreset/default.jsonremains a reasonable (optional) cleanup once legacy consumers migrate.Nothing here blocks the change: the config is valid, additive-only, and the guidance files were updated in the same PR.
*🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: approve
Code review findings from opencode.
@ -2,4 +2,0 @@"$schema": "https://docs.renovatebot.com/renovate-schema.json","reviewers": ["@martin"],"extends": ["config:recommended", ":semanticCommits"],"nix": {Fixed
@ -1,9 +1,13 @@{"$schema": "https://docs.renovatebot.com/renovate-schema.json","reviewers": ["@martin"],"extends": ["config:recommended", ":semanticCommits"],@ -1,9 +1,13 @@{It will be dropped later
@ -9,0 +2,4 @@"$schema": "https://docs.renovatebot.com/renovate-schema.json","extends": ["config:recommended",":enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)"Code review findings from opencode.
@ -9,0 +3,4 @@"extends": ["config:recommended",":semanticCommits",":enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)"