refactor(renovate): consolidate shared default config #5

Merged
martin merged 2 commits from refactor/consolidate-default-config into main 2026-10-25 15:53:49 +00:00
Owner

Summary

  • Copy the configuration from preset/default.json into the root default.json.
  • Switch organization onboarding to extend the root preset.
  • Keep preset/default.json for existing consumers and update repository guidance.

Validation

  • just validate default.json
  • just validate org-inherited-config.json
## Summary - Copy the configuration from `preset/default.json` into the root `default.json`. - Switch organization onboarding to extend the root preset. - Keep `preset/default.json` for existing consumers and update repository guidance. ## Validation - `just validate default.json` - `just validate org-inherited-config.json`
refactor(renovate): consolidate shared default config
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
ce6e2d28c0
Co-authored-by: OpenCode <opencode@anoma.ly>
Member

Review Summary

Correctness checks (this version of the diff)

  • The diff is a union merge, not the behavior-reducing copy described in earlier comments: the new root default.json retains :semanticCommits, "nix": {"enabled": true} and "osvVulnerabilityAlerts": true, and only adds :enableVulnerabilityAlertsWithAdditionalLabel(vulnerability) plus "labels": ["dependencies"]. The previously raised concerns about silently dropping Nix/OSV/semantic-commit settings do not apply to the current diff.
  • :enableVulnerabilityAlertsWithAdditionalLabel(vulnerability) is a real internal preset (it sets vulnerabilityAlerts.enabled = true plus addLabels: ["vulnerability"]), and it composes cleanly with osvVulnerabilityAlerts and the repo-level labels entry — addLabels merges with labels, so security PRs get both labels rather than replacing them.
  • org-inherited-config.json's new Personal/renovate-config reference is valid: an unprefixed owner/repo string parses as a local-source preset with presetName: "default", so it resolves to default.json on the default branch — exactly equivalent to the old //preset/default form, just pointing at the root file. Docs in AGENTS.md and .opencode/skills/renovate-presets/SKILL.md describe this correctly and are consistent with each other.
  • Validation was run on both changed JSON files, matching the repo's just validate <path> guidance.

Notes (non-blocking)

  • The PR description says the config was "copied" from preset/default.json, but the result is a merge that also introduces two behaviors existing root-default consumers did not have before (vulnerability-alert PRs and the dependencies label). Worth one line in the description so downstream maintainers can see the additions, not just the consolidation.
  • Root default.json is now a strict superset of preset/default.json, so the two defaults can still drift apart in the future; the previously suggested thin-wrapper follow-up for preset/default.json remains a reasonable (optional) cleanup once legacy consumers migrate.

Nothing here blocks the change: the config is valid, additive-only, and the guidance files were updated in the same PR.


*🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: approve

# Review Summary **Correctness checks (this version of the diff)** - The diff is a *union* merge, not the behavior-reducing copy described in earlier comments: the new root `default.json` retains `:semanticCommits`, `"nix": {"enabled": true}` and `"osvVulnerabilityAlerts": true`, and only adds `:enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)` plus `"labels": ["dependencies"]`. The previously raised concerns about silently dropping Nix/OSV/semantic-commit settings do not apply to the current diff. - `:enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)` is a real internal preset (it sets `vulnerabilityAlerts.enabled = true` plus `addLabels: ["vulnerability"]`), and it composes cleanly with `osvVulnerabilityAlerts` and the repo-level `labels` entry — `addLabels` merges with `labels`, so security PRs get both labels rather than replacing them. - `org-inherited-config.json`'s new `Personal/renovate-config` reference is valid: an unprefixed `owner/repo` string parses as a `local`-source preset with `presetName: "default"`, so it resolves to `default.json` on the default branch — exactly equivalent to the old `//preset/default` form, just pointing at the root file. Docs in `AGENTS.md` and `.opencode/skills/renovate-presets/SKILL.md` describe this correctly and are consistent with each other. - Validation was run on both changed JSON files, matching the repo's `just validate <path>` guidance. **Notes (non-blocking)** - The PR description says the config was "copied" from `preset/default.json`, but the result is a merge that also introduces two behaviors existing root-default consumers did not have before (vulnerability-alert PRs and the `dependencies` label). Worth one line in the description so downstream maintainers can see the additions, not just the consolidation. - Root `default.json` is now a strict superset of `preset/default.json`, so the two defaults can still drift apart in the future; the previously suggested thin-wrapper follow-up for `preset/default.json` remains a reasonable (optional) cleanup once legacy consumers migrate. Nothing here blocks the change: the config is valid, additive-only, and the guidance files were updated in the same PR. --- *🤖 Review by opencode (opencode/mimo-v2.6-flash-free) — verdict: **approve** <!-- forgejo-opencode-review -->
clank-bot left a comment

Code review findings from opencode.

Code review findings from opencode. <!-- forgejo-opencode-review -->
@ -2,4 +2,0 @@
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"reviewers": ["@martin"],
"extends": ["config:recommended", ":semanticCommits"],
"nix": {
Member
[bug] Removing `"nix": { "enabled": true }` disables the Nix manager for every consumer extending the root default — the `nix` manager defaults to `enabled: false` (beta/opt-in) and is not enabled by `config:recommended`. Consumers with `flake.nix` files that rely on the shared default (rather than `preset/flake.json`) will silently stop receiving Nix updates. Confirm intentional and note this breaking change in the PR description, since `preset/flake.json` only covers consumers who extend it.
<!-- forgejo-opencode-review --> [bug] Removing `"nix": { "enabled": true }` disables the Nix manager for every consumer extending the root default — the `nix` manager defaults to `enabled: false` (beta/opt-in) and is not enabled by `config:recommended`. Consumers with `flake.nix` files that rely on the shared default (rather than `preset/flake.json`) will silently stop receiving Nix updates. Confirm intentional and note this breaking change in the PR description, since `preset/flake.json` only covers consumers who extend it.
Author
Owner

Fixed

Fixed
martin marked this conversation as resolved
@ -1,9 +1,13 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"reviewers": ["@martin"],
"extends": ["config:recommended", ":semanticCommits"],
Member
[style] `:semanticCommits` is also dropped by this consolidation, so consumer repos extending the root default lose semantic commit messages. Not mentioned in the PR summary — worth confirming it was intentional (or restoring it) alongside the `nix` and `osvVulnerabilityAlerts` removals.
<!-- forgejo-opencode-review --> [style] `:semanticCommits` is also dropped by this consolidation, so consumer repos extending the root default lose semantic commit messages. Not mentioned in the PR summary — worth confirming it was intentional (or restoring it) alongside the `nix` and `osvVulnerabilityAlerts` removals.
martin marked this conversation as resolved
@ -1,9 +1,13 @@
{
Member
[style] `default.json` and `preset/default.json` are now effectively identical copies, which is exactly how they drifted apart before this PR. To keep the root as the single source of truth while legacy consumers keep working, consider reducing `preset/default.json` to `{ "extends": ["Personal/renovate-config"] }` (follow-up is fine).
<!-- forgejo-opencode-review --> [style] `default.json` and `preset/default.json` are now effectively identical copies, which is exactly how they drifted apart before this PR. To keep the root as the single source of truth while legacy consumers keep working, consider reducing `preset/default.json` to `{ "extends": ["Personal/renovate-config"] }` (follow-up is fine).
Author
Owner

It will be dropped later

It will be dropped later
martin marked this conversation as resolved
@ -9,0 +2,4 @@
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:recommended",
":enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)"
Member
[security] This preset does not replace the removed `"osvVulnerabilityAlerts": true`. `:enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)` only sets `vulnerabilityAlerts.enabled = true` plus `addLabels`, which drives GitHub Dependabot-alert-based PRs; `osvVulnerabilityAlerts` enabled platform-independent OSV-database detection. Dropping it silently reduces vulnerability coverage for existing consumers of the root default (and removes it entirely on non-GitHub hosts). Please confirm this is intentional, or keep `"osvVulnerabilityAlerts": true` alongside the preset.
<!-- forgejo-opencode-review --> [security] This preset does not replace the removed `"osvVulnerabilityAlerts": true`. `:enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)` only sets `vulnerabilityAlerts.enabled = true` plus `addLabels`, which drives GitHub Dependabot-alert-based PRs; `osvVulnerabilityAlerts` enabled platform-independent OSV-database detection. Dropping it silently reduces vulnerability coverage for existing consumers of the root default (and removes it entirely on non-GitHub hosts). Please confirm this is intentional, or keep `"osvVulnerabilityAlerts": true` alongside the preset.
martin marked this conversation as resolved
fix(renovate): preserve existing default settings
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
571cf3275c
Co-authored-by: OpenCode <opencode@anoma.ly>
clank-bot left a comment

Code review findings from opencode.

Code review findings from opencode. <!-- forgejo-opencode-review -->
@ -9,0 +3,4 @@
"extends": [
"config:recommended",
":semanticCommits",
":enableVulnerabilityAlertsWithAdditionalLabel(vulnerability)"
Member
[style] The PR description frames this as a straight copy of `preset/default.json`, but for existing consumers of the root default these are additive behavior changes: `vulnerabilityAlerts` becomes enabled (with a `vulnerability` label) and `labels: ["dependencies"]` starts being applied to every PR. Please mention these additions in the PR summary alongside the settings that are preserved (`nix`, `osvVulnerabilityAlerts`, `:semanticCommits`), so downstream repos know what changes when they pick up the new default.
<!-- forgejo-opencode-review --> [style] The PR description frames this as a straight copy of `preset/default.json`, but for existing consumers of the root default these are additive behavior changes: `vulnerabilityAlerts` becomes enabled (with a `vulnerability` label) and `labels: ["dependencies"]` starts being applied to every PR. Please mention these additions in the PR summary alongside the settings that are preserved (`nix`, `osvVulnerabilityAlerts`, `:semanticCommits`), so downstream repos know what changes when they pick up the new default.
martin self-assigned this 2026-10-25 15:53:06 +00:00
martin merged commit 11eb7098d9 into main 2026-10-25 15:53:49 +00:00
martin deleted branch refactor/consolidate-default-config 2026-10-25 15:53:49 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Personal/renovate-config!5
No description provided.