feat: Add Playwright integration test #51
No reviewers
Labels
No labels
bug
dependency
duplicate
enhancement
help wanted
invalid
question
vulnerability
wontfix
automerge
bug
dependencies
duplicate
help wanted
invalid
lang
rust
migrations
opencode
question
security
type
documentation
type
enhancement
type
maintenance
type
refactor
vulnerability
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Reference
Personal/toolbox!51
Loading…
Reference in a new issue
No description provided.
Delete branch "tests/playwright"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Review Summary
This PR adds a minimal Playwright end-to-end integration test for the Astro/Bun production startup. The implementation is clean and well-structured: a focused smoke test, proper config using Nix-provided Chromium via
PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH, explicitreuseExistingServer: falseto prevent stale processes, and thorough documentation in bothAGENTS.mdandREADME.mdexplaining the known Bun/Astro adapter issue (app.pipeline.getLoggerundefined).The prior review already flagged the
flake.nixfish shell change (confirmed intentional by author) and the performance consideration around rebuild-per-test. No new correctness or security issues found. The largebun.lock/bun.nixdependency bumps are routine version updates and not concerning on their own.*🤖 Review by opencode (opencode/mimo-v2.5-free) — verdict: approve
Code review findings from opencode.
@ -130,2 +130,4 @@# Use the Nix browser instead of downloading Playwright browsers.chromium];shellHook = ''This is intentional
@ -9,6 +9,7 @@"dev": "bunx --bun astro dev","build": "bun run generate && bunx --bun astro build","check": "bunx --bun astro check","test:e2e": "bun run build && bunx playwright test",@ -0,0 +27,4 @@],webServer: {// Use the compiled server to test production startup with Bun.command: "HOST=127.0.0.1 PORT=4323 bun dist/server/entry.mjs",