Replace swagger drv with utoipa-swagger-vendored #14

Merged
martin merged 1 commit from utoipa-swagger-vendored into main 2026-07-21 17:51:31 +00:00
Owner
@clank-bot
martin self-assigned this 2026-07-21 17:39:15 +00:00
Replace swagger drv with utoipa-swagger-vendored
Some checks failed
ci/woodpecker/pr/pr-review Pipeline was successful
ci/woodpecker/push/verify Pipeline was canceled
1d8ee1fb43
martin force-pushed utoipa-swagger-vendored from 1d8ee1fb43
Some checks failed
ci/woodpecker/pr/pr-review Pipeline was successful
ci/woodpecker/push/verify Pipeline was canceled
to 6ae8c6f539
All checks were successful
ci/woodpecker/pr/pr-review Pipeline was successful
ci/woodpecker/push/verify Pipeline was successful
2026-07-21 17:40:16 +00:00
Compare
Member

Review Summary

This PR replaces the Nix-based Swagger UI download with the vendored feature of utoipa-swagger-ui, simplifying the build system. The Nix derivation no longer fetches Swagger UI from GitHub at build time — instead, the utoipa-swagger-ui-vendored crate bundles the assets directly. Cargo.lock updates are routine transitive dependency bumps from this change.

Positive aspects

  • Simpler build: Removes manual fetchurl + SWAGGER_UI_DOWNLOAD_URL env var in favor of Cargo's built-in vendoring.
  • Security improvement: Eliminates an external network fetch at build time; the vendored crate is cached and verified by Cargo.
  • Cleaner dependency tree: Removes transitive WASM/WIT crates (anyhow, wit-bindgen, wasmparser, etc.) that were only pulled in by the old approach.

No bugs, security vulnerabilities, or performance regressions found.


*🤖 Review by opencode (opencode/deepseek-v4-flash-free) — verdict: approve

# Review Summary This PR replaces the Nix-based Swagger UI download with the vendored feature of `utoipa-swagger-ui`, simplifying the build system. The Nix derivation no longer fetches Swagger UI from GitHub at build time — instead, the `utoipa-swagger-ui-vendored` crate bundles the assets directly. Cargo.lock updates are routine transitive dependency bumps from this change. ## Positive aspects - **Simpler build**: Removes manual `fetchurl` + `SWAGGER_UI_DOWNLOAD_URL` env var in favor of Cargo's built-in vendoring. - **Security improvement**: Eliminates an external network fetch at build time; the vendored crate is cached and verified by Cargo. - **Cleaner dependency tree**: Removes transitive WASM/WIT crates (`anyhow`, `wit-bindgen`, `wasmparser`, etc.) that were only pulled in by the old approach. No bugs, security vulnerabilities, or performance regressions found. --- *🤖 Review by opencode (opencode/deepseek-v4-flash-free) — verdict: **approve**
martin merged commit e066a6a32d into main 2026-07-21 17:51:31 +00:00
martin deleted branch utoipa-swagger-vendored 2026-07-21 17:51:31 +00:00
Sign in to join this conversation.
No description provided.