feat: Expose json schema for config file #30

This PR adds JSON Schema generation for the configuration file using the schemars crate. The schema is exposed via an HTTP endpoint (/config.schema.json) and installed as a file in the Nix package. The implementation is solid and well-structured.

Positives:

Comprehensive validation ensures the config schema path doesn't conflict with other built-in endpoints
Good test coverage including schema endpoint validation and conflict detection
Proper Nix packaging with postInstall to generate and install the schema file
Clean use of #[cfg_attr(test, derive(Default))] instead of manual Default impls
Nice iterator refactor in http_signature.rs
The config-schema binary approach is clean for generating the schema independently

Minor concerns:

The #[allow(dead_code)] in src/bin/config-schema.rs is technically unnecessary since the schema is generated via derive macros, not direct usage
The justfile run recipe change to @ (silent) is a behavior change mixed into an unrelated feature PR
Some style-only changes (return removal, .map(|s| s) → .collect()) are mixed in; these could be separate cleanup commits

*🤖 Review by opencode (opencode/mimo-v2.5-free) — verdict: approve

# Review Summary This PR adds JSON Schema generation for the configuration file using the `schemars` crate. The schema is exposed via an HTTP endpoint (`/config.schema.json`) and installed as a file in the Nix package. The implementation is solid and well-structured. **Positives:** - Comprehensive validation ensures the config schema path doesn't conflict with other built-in endpoints - Good test coverage including schema endpoint validation and conflict detection - Proper Nix packaging with postInstall to generate and install the schema file - Clean use of `#[cfg_attr(test, derive(Default))]` instead of manual Default impls - Nice iterator refactor in `http_signature.rs` - The `config-schema` binary approach is clean for generating the schema independently **Minor concerns:** - The `#[allow(dead_code)]` in `src/bin/config-schema.rs` is technically unnecessary since the schema is generated via derive macros, not direct usage - The `justfile` `run` recipe change to `@` (silent) is a behavior change mixed into an unrelated feature PR - Some style-only changes (`return` removal, `.map(|s| s)` → `.collect()`) are mixed in; these could be separate cleanup commits --- *🤖 Review by opencode (opencode/mimo-v2.5-free) — verdict: **approve**

clank-bot reviewed

2026-09-16 20:00:17 +00:00

clank-bot left a comment

Code review findings from opencode.

Code review findings from opencode.

justfile

					
				@ -13,3 +13,2 @@

				[group("Cargo")]

				run $WOODPECKER_EXTENSION_CONFIG=DEV_CONFIG:

				    cargo run

				@run $WOODPECKER_EXTENSION_CONFIG=DEV_CONFIG:

[style] The `@` prefix on `run` silences command echo, which is a behavior change unrelated to the schema feature. This should be a separate commit or noted in the PR description.

[style] The `@` prefix on `run` silences command echo, which is a behavior change unrelated to the schema feature. This should be a separate commit or noted in the PR description.

src/bin/config-schema.rs

					
				@ -0,0 +1,16 @@

				#![allow(dead_code)]

[style] `#[allow(dead_code)]` is unnecessary here — the config module types are used through `schema_for!` derive macros, not direct function calls. Consider removing it for clarity.

[style] `#[allow(dead_code)]` is unnecessary here — the config module types are used through `schema_for!` derive macros, not direct function calls. Consider removing it for clarity.