Personal/woodpecker-plugins
Watch
2
0
Fork
You've already forked woodpecker-plugins
 0
Code Issues 1 Pull requests 3 Projects Releases Packages 7 Wiki Activity Actions

fix(forgejo-opencode-review): Test failures due to tempdir #39

Merged
martin merged 2 commits from nextest-fixes into main 2026-08-23 11:38:55 +00:00
Conversation 1 Commits 2 Files changed 4 +124 -111
martin commented 2026-08-22 21:58:10 +00:00
Owner
Copy link
No description provided.
martin self-assigned this 2026-08-22 21:58:10 +00:00
fix(forgejo-opencode-review): Test failures due to tempdir
Some checks failed
ci/woodpecker/pr/pr-review Pipeline was successful
Details
ci/woodpecker/pr/global-rust-verify Pipeline failed
Details
ci/woodpecker/push/verify-nix Pipeline was successful
Details
2270972133
clank-bot commented 2026-08-22 21:59:13 +00:00
Member
Copy link

Review Summary

This PR refactors the forgejo-opencode-review plugin to improve testability by introducing an OpenCodeRunner trait for dependency injection, replacing the fragile PATH manipulation approach with a clean abstraction. The OpenCodeBuilder in core now supports a configurable executable path. Tests are updated to use Result with ? operator instead of unwrap(). The changes are well-structured and follow Rust best practices.

Key improvements:

  • Dependency injection via OpenCodeRunner trait enables clean unit testing
  • Removal of unsafe std::env::set_var calls in tests (which are deprecated in Rust 2024)
  • More idiomatic error handling in tests
  • Addition of cargo-nextest to dev shell for faster test runs

No correctness, security, or performance issues found.

*🤖 Review by opencode (opencode/nemotron-3-ultra-free) — verdict: approve

# Review Summary This PR refactors the `forgejo-opencode-review` plugin to improve testability by introducing an `OpenCodeRunner` trait for dependency injection, replacing the fragile PATH manipulation approach with a clean abstraction. The `OpenCodeBuilder` in core now supports a configurable executable path. Tests are updated to use `Result` with `?` operator instead of `unwrap()`. The changes are well-structured and follow Rust best practices. **Key improvements:** - Dependency injection via `OpenCodeRunner` trait enables clean unit testing - Removal of unsafe `std::env::set_var` calls in tests (which are deprecated in Rust 2024) - More idiomatic error handling in tests - Addition of `cargo-nextest` to dev shell for faster test runs No correctness, security, or performance issues found. --- *🤖 Review by opencode (opencode/nemotron-3-ultra-free) — verdict: **approve** <!-- forgejo-opencode-review -->
fix: Fsiling test in core
Some checks failed
ci/woodpecker/pr/pr-review Pipeline failed
Details
ci/woodpecker/pr/global-rust-verify Pipeline was successful
Details
ci/woodpecker/push/verify-nix Pipeline was successful
Details
50084a1aed
martin merged commit b546f20d22 into main 2026-08-23 11:38:55 +00:00
martin deleted branch nextest-fixes 2026-08-23 11:38:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
clank-bot
Labels
Clear labels
  
automerge
Merge pull requests automatically after checks have completed

  
bug
Something is not working

  
dependencies
Dependency updates

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
migrations
Automated repo migration

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
automerge
bug
dependencies
duplicate
enhancement
help wanted
invalid
migrations
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
martin
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
Personal/woodpecker-plugins!39
No description provided.