ci(verify-nix): Only build changed plugins #40

The PR introduces a valuable optimization to only build changed Nix plugins instead of all plugins on every run. The approach is sound: detect changed files via CI_PIPELINE_FILES, classify changes as either shared infrastructure (triggering full build) or plugin-specific (building only affected plugins).

However, there's a critical bug in the shell script where $$ is used instead of $ for parameter expansion (lines 70-71). This will cause plugin name extraction to fail completely, as $$ expands to the shell's PID rather than performing the intended string manipulation.

Other observations:

The expanded trigger paths are comprehensive and correct
Conservative fallback to full build on parse errors is appropriate
Cachix push error handling is reasonable for CI
Script complexity is high for inline YAML; consider extracting to a separate script file for maintainability

*🤖 Review by opencode (opencode/nemotron-3-ultra-free) — verdict: changes

# Review Summary The PR introduces a valuable optimization to only build changed Nix plugins instead of all plugins on every run. The approach is sound: detect changed files via `CI_PIPELINE_FILES`, classify changes as either shared infrastructure (triggering full build) or plugin-specific (building only affected plugins). However, there's a **critical bug** in the shell script where `$$` is used instead of `$` for parameter expansion (lines 70-71). This will cause plugin name extraction to fail completely, as `$$` expands to the shell's PID rather than performing the intended string manipulation. Other observations: - The expanded trigger paths are comprehensive and correct - Conservative fallback to full build on parse errors is appropriate - Cachix push error handling is reasonable for CI - Script complexity is high for inline YAML; consider extracting to a separate script file for maintainability --- *🤖 Review by opencode (opencode/nemotron-3-ultra-free) — verdict: **changes**

clank-bot reviewed

2026-08-23 13:15:59 +00:00

clank-bot left a comment

Code review findings from opencode.

Code review findings from opencode.

.woodpecker/verify-nix.yaml

					
				@ -32,0 +67,4 @@

				                case " $plugins " in

				                  *" $plugin "*) ;;

				                  *) plugins="$plugins $plugin" ;;

				                esac

[bug] Using $$ for parameter expansion is incorrect. In shell, $$ expands to the process ID. Should be ${path#plugins/} (single $). This bug will cause plugin name extraction to fail.

[bug] Using $$ for parameter expansion is incorrect. In shell, $$ expands to the process ID. Should be ${path#plugins/} (single $). This bug will cause plugin name extraction to fail.

This is not correct, in woodpecker ${} will be replaced by the woodpecker preprocessor, while $${} must be used for shell variables

.woodpecker/verify-nix.yaml

					
				@ -32,0 +68,4 @@

				                  *" $plugin "*) ;;

				                  *) plugins="$plugins $plugin" ;;

				                esac

				                ;;

[bug] Same bug: $$ should be $ for parameter expansion. Should be ${plugin%%/*}

[bug] Same bug: $$ should be $ for parameter expansion. Should be ${plugin%%/*}

ci/woodpecker/pr/verify-nix Pipeline failed

Details

ci/woodpecker/pr/pr-review Pipeline was successful

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin refactor/verify-nix:refactor/verify-nix

git switch refactor/verify-nix

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff refactor/verify-nix

git switch refactor/verify-nix

git rebase main

git switch main

git merge --ff-only refactor/verify-nix

git switch refactor/verify-nix

git rebase main

git switch main

git merge --no-ff refactor/verify-nix

git switch main

git merge --squash refactor/verify-nix